Move mods_base.raw_keybinds to keybinds.raw_keybinds, init script improvements
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after trying it out, this interface doesn't really make sense in willow luckily it's not really a used interface yet
hook up the warning system, found a new proton bug, rename the extra folders env var for consistency
only using pylance latest was causing issues in dependencies of this repo pyunrealsdk was already using pyright latest, so we really ought to copy it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes from working on the willow mod manager. The interface has proven difficult to implement in willow, and it doesn't actually see much use for it. Willow has a lot more access to the UI, you can directly hook inputs on the specific GUI you're interested in, so there's little point in using
raw_keybinds. It's still handy in oak, so let's make it oak-specific.The only external mod using raw keybinds is my Hunt Tracker, which I've already put up an update for in apple1417/oak-sdk-mods#5. This means we don't really need to leave compatibility.
Also contains some extra warnings I found for the init script.